Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Militia Community Addendum #74865

Merged

Conversation

RanikOrtega
Copy link
Contributor

Update to #73053 with pallete cleanup, item list cleanup and better map layout.

Summary

Content "Militia community follow up"

Purpose of change

Improve initial commit of the Militia community. Rotation, item cleanup and map layout has been improved.

Describe the solution

Cleaned up item list for merchant, improved map palette + Layout, overmap rotation etc etc

Describe alternatives you've considered

Not doing those.

Testing

Tested Overmap Spawn and rotations successfully.

Additional context

Update to CleverRaven#73053 with pallete cleanup, item list cleanup and better map layout.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 2, 2024
@RanikOrtega
Copy link
Contributor Author

Changes look good. Only failed test is unrelated item test. Ready for review and approval or test re-kick.

@Maleclypse Maleclypse merged commit 6052b16 into CleverRaven:master Jul 3, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants